Skip to content

entrypoint_user_scripts.sh: ensure pip runs in venv #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edgar-vincent wants to merge 1 commit into from
Closed

entrypoint_user_scripts.sh: ensure pip runs in venv #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions docker/entrypoints/entrypoint_user_scripts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,34 @@ SCRIPT_DIR=$(dirname "$0")
export PIP_DISABLE_PIP_VERSION_CHECK=1
export PIP_ROOT_USER_ACTION=ignore

VENV_PY="/repo/backend/.venv/bin/python"

ensure_backend_pip() {
if [ ! -x "$VENV_PY" ]; then
log "ERROR: backend venv python not found or not executable at $VENV_PY"
return 1
fi

# If pip is missing in the venv, try to bootstrap it via ensurepip.
if ! "$VENV_PY" -m pip --version >/dev/null 2>&1; then
log "pip missing in backend venv; bootstrapping via ensurepip"
"$VENV_PY" -m ensurepip --upgrade >/dev/null 2>&1 || true
fi

# Guardrail: refuse to continue if pip still isn't available in the venv.
"$VENV_PY" -m pip --version >/dev/null 2>&1 || {
log "ERROR: pip is not available in backend venv (/repo/backend/.venv). Refusing to install requirements outside the venv."
return 1
}
}

install_requirements() {
local req_file="$1"
log "Installing pip requirements from $req_file"
ensure_backend_pip || return 1
"$VENV_PY" -m pip install --no-cache-dir -r "$req_file"
}

# check for user startup scripts
if [ -f /config/startup.sh ]; then
log "Running user startup script from /config/startup.sh"
Expand All @@ -15,13 +43,10 @@ if [ -f /config/beets-flask/startup.sh ]; then
/config/beets-flask/startup.sh
fi


# check for requirements.txt
if [ -f /config/requirements.txt ]; then
log "Installing pip requirements from /config/requirements.txt"
pip install -r /config/requirements.txt
install_requirements /config/requirements.txt || exit 1
fi
if [ -f /config/beets-flask/requirements.txt ]; then
log "Installing pip requirements from /config/beets-flask/requirements.txt"
pip install -r /config/beets-flask/requirements.txt
install_requirements /config/beets-flask/requirements.txt || exit 1
fi