Fix TMR export for combined timer effects#31
Merged
Conversation
Regression coverage for the waveform export bugfix: a two-shape syncbuzzer must export both shapes as a 2-event chain alternating A->B->A (not a single self-looping event with shape B dropped). Also covers single-shape self-loop and a parse round-trip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
paator
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge coexisting sync-buzzer/SID/FM/Env+FM effects into one timer chain without
dropping register writes
Preserve waveform loop points and PWM retune timing in cached event chains
Add regressions for merged chains, PWM low-period changes, and merged-to-single
transitions
Serve public JS module imports correctly in Vite dev mode