Change RX sampling time to happen in the middle of the bit#1
Open
sd2k9 wants to merge 2 commits intopabennett:masterfrom
Open
Change RX sampling time to happen in the middle of the bit#1sd2k9 wants to merge 2 commits intopabennett:masterfrom
sd2k9 wants to merge 2 commits intopabennett:masterfrom
Conversation
added 2 commits
June 30, 2013 18:55
* Sample the RX data bits in the MIDDLE of the bit to be more robust,
Synchronise the sampling point to every start bit received
Also add "Optimize Here" Markers for later trials - ignore them for now
Original Resources for Example CoolRunner II Project:
|Macrocells |Product Terms |Function Block |Registers |Pins |
|Used/Tot |Used/Tot |Inps Used/Tot |Used/Tot |Used/Tot |
|229/256 ( 89%) |458 /896 ( 51%) |472 /640 ( 74%) |178/256 ( 70%) |20 /118 ( 17%)|
Resources for this commit:
|Macrocells |Product Terms |Function Block |Registers |Pins |
|Used/Tot |Used/Tot |Inps Used/Tot |Used/Tot |Used/Tot |
|164/256 ( 64%) |339 /896 ( 38%) |376 /640 ( 59%) |119/256 ( 46%) |20 /118 ( 17%)|
|
Hi, I would like to know if your commit 8c0cc8e (date: Jan 14th, 2016) is the equivalent of merging this pull request? Thanks!! |
Owner
|
Yes I believe so. I revisited the project back in January to fix a few outstanding bugs, one of which was the bit alignment. |
|
I was asking because this pull request is still open. Thanks for the great project by the way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I used your project as starting point for implementing an UART module. While investigating it I found that the RX sampling happens very early inside a bit, see the commited before.png
This isn't very robust and could cause troube with faulty data sampling.
Therefore I changed the code to sample in the middle of the bit, as you can see in after.png
The change is rather large because I detected the issue during my rework of reducing the logic usage for CPLD, by removing the double sampling clock generation counters.
And I also added "Optimize Here" Markers for later trials - please ignore them for now.
Just let me know if something is unclear.
You can find my testbench and project setup here in case you're interested:
https://github.com/sd2k9/hdl_uart_echo