This repository was archived by the owner on May 12, 2021. It is now read-only.
utilize tokenizer for use indexing#28
Open
goatherd wants to merge 1 commit intopackfire-archived:developfrom
Open
utilize tokenizer for use indexing#28goatherd wants to merge 1 commit intopackfire-archived:developfrom
goatherd wants to merge 1 commit intopackfire-archived:developfrom
Conversation
Contributor
|
Hi @goatherd :D Thanks for the awesome move to use tokenizer. I've briefly gone through the patch and saw that a case has been left out. |
Contributor
Author
|
Hi @thephpdeveloper, the method is described as get all use declarations by alias. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplied a test case for
Analyzer::useIndexing()and re-implemented the method using the tokenized source.Performance impact is roughly halved for both memory and execution time of this step.