Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

utilize tokenizer for use indexing#28

Open
goatherd wants to merge 1 commit intopackfire-archived:developfrom
goatherd:tokenizer-indexing
Open

utilize tokenizer for use indexing#28
goatherd wants to merge 1 commit intopackfire-archived:developfrom
goatherd:tokenizer-indexing

Conversation

@goatherd
Copy link
Copy Markdown
Contributor

Supplied a test case for Analyzer::useIndexing() and re-implemented the method using the tokenized source.

Performance impact is roughly halved for both memory and execution time of this step.

@mauris
Copy link
Copy Markdown
Contributor

mauris commented May 4, 2013

Hi @goatherd :D Thanks for the awesome move to use tokenizer. I've briefly gone through the patch and saw that a case has been left out. use can also be used within class{} to denote usage of traits by the class.

@goatherd
Copy link
Copy Markdown
Contributor Author

goatherd commented May 4, 2013

Hi @thephpdeveloper,

the method is described as get all use declarations by alias. Use statements in class context do rather consume than declare a namespace. Therefore the parser will stop on the first occurrence of a class/interface/trait keyword.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants