Skip to content

feat(slice-4c.1): Profile delete confirmation modal #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lopadova merged 11 commits into from
May 19, 2026
+587 −7
Merged

feat(slice-4c.1): Profile delete confirmation modal #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ee0354
feat(slice-4c.1): Profile delete confirmation modal wired to DELETE /…
lopadova May 19, 2026
037f73c
fix(slice-4c.1): drop deleted row from list, rendered JSX subtitle, s…
lopadova May 19, 2026
fda116b
fix(slice-4c.1): not-found state for unknown profile, sync in-flight ref
lopadova May 19, 2026
b3b60c7
fix(slice-4c.1): lift deletedProfiles to App so it survives route cha…
lopadova May 19, 2026
c34d1b1
fix(slice-4c.1): sync inFlightRef with reset effect on profile switch
lopadova May 19, 2026
3a9a281
test(slice-4c.1): tighten route mock to DELETE-only and real response…
lopadova May 19, 2026
d5a4354
test(slice-4c.1): fix vacuous row-removal selector caught by Copilot
lopadova May 19, 2026
0ba0eb8
fix(slice-4c.1): stale-submit guard via captured submittedName
lopadova May 19, 2026
dfd0cf3
fix(slice-4c.1): synchronous reset on handleClose + close/reopen regr…
lopadova May 19, 2026
9f34c67
fix(slice-4c.1): no profile-detail fallback + inert modal close durin…
lopadova May 19, 2026
d7af60d
fix(slice-4c.1): definite-assignment for promise resolver in delete-i…
lopadova May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/internal/admin-placeholder-audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ The line numbers below were captured against commit `~v1.6.0` (post-merge of PR

### Profiles (lines ~5500-5950)

- `5590`, `5745`, `5796` — profile-level actions (save/clone/delete)
- `5590`, `5745`, `5796` — profile-level actions (save/clone/delete) — **DELETE shipped in PR #29 (slice 4c.1):** Profile detail page now has a Delete button → opens type-to-confirm modal → DELETE `/api/profiles/:name`. Save/Clone still pending.
- `5927`, `5931`, `5935`, `5939` — pack picker

### Agents (lines ~6500-6630)
Expand Down
Loading
Loading