feat: [IOPLT-1555] Properly handles app language selection and persistence#7817
feat: [IOPLT-1555] Properly handles app language selection and persistence#7817CrisTofani merged 44 commits intomasterfrom
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7817 +/- ##
==========================================
+ Coverage 60.02% 60.04% +0.02%
==========================================
Files 1966 1966
Lines 43860 43844 -16
Branches 10144 10061 -83
==========================================
+ Hits 26326 26327 +1
+ Misses 17446 17438 -8
+ Partials 88 79 -9
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dmnplb
left a comment
There was a problem hiding this comment.
Just fixed some wrong (or missing) translations in the de and en locales, then added a logic to display the locales in the following order, according to the design specs:
it,en(pinned)- the other ones sorted alphabetically
In my opinion, we can release the new screen without hesitation ✌🏻
LeleDallas
left a comment
There was a problem hiding this comment.
We can omit some unnecessary assertions
@LeleDallas All addressed in 9c35d21 |
Short description
This pull request refactors and simplifies the language and locale selection logic in the application streamlining related state management. It also cleans up unused saga code related to language preference synchronization and sets a default preferred language. The changes focus on improving maintainability and user experience for language selection in the preferences screen.
List of changes proposed in this pull request
How to test
Change the selected language on Preferences > Preferred Language screen
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-03-02.at.15.58.01.mov