feat: [IOPLT-1572] Adds expo-modules support and install expo-screen-capture#7840
feat: [IOPLT-1572] Adds expo-modules support and install expo-screen-capture#7840CrisTofani merged 12 commits intomasterfrom
Conversation
|
I think the |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7840 +/- ##
=======================================
Coverage 60.26% 60.26%
=======================================
Files 1968 1968
Lines 43943 43943
Branches 10140 10141 +1
=======================================
Hits 26482 26482
+ Misses 17383 17372 -11
- Partials 78 89 +11
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I’ve linked issue #7828 to this PR. While investigating, I identified |
LeleDallas
left a comment
There was a problem hiding this comment.
Tested B&P flow with iOS and Android real devices and I didn't spot any regressions!
I also confirm that it solves #7828 as @mastro993 said
Note
This PR requires to elevate min iOS version to
15.1Short description
This PR installs expo and fixes related dependencies to build on both iOS and Android.
Furthermore in this PR the first expo-module has been installed, replacing previous react-native module.
expo-screen-capturetakes place ofreact-native-screenshot-preventremoving the related references and patch.List of changes proposed in this pull request
expo@pagopa/react-native-cieon iOSreact-native-screenshot-preventwithexpo-screen-captureHow to test
To test the PR follow these steps:
node_modulesrunninngrm -rf node_modulescd ios; rm -rf Pods; rm -rf DerivedDatayarn installyarn dev:pod-install