Skip to content

fix: [IEL-56] Pdf flashing during sign#7857

Closed
freddi301 wants to merge 7 commits intomasterfrom
IEL-56-sign-pdf-blinking
Closed

fix: [IEL-56] Pdf flashing during sign#7857
freddi301 wants to merge 7 commits intomasterfrom
IEL-56-sign-pdf-blinking

Conversation

@freddi301
Copy link
Copy Markdown
Contributor

@freddi301 freddi301 commented Feb 11, 2026

Short description

This PR addresses a graphical glitch happening when viewing pdf documents to sign.
It happens when changing screen. There three variations of this:

  • viewing the document for the first time a white blink happens
  • viewing a subsequent document shows the old one for a split second
  • viewing clauses if affected by the same

After a thorough investigation we discovered that it was due to downloadUrl pot contains previous document url when viewwing the affected screens.
Affected components:

  • FciDocumentsScreen.tsx
  • DocumentWithSignature.tsx
  • DocumentViewer.tsx

In the end we decided to fix only one occurrence, since there weren't issue reported from users:

  • FciDocumentsScreen.tsx when doing from document one to docuement two

We left unsolved the other:

  • flashing, first and subsequent when viewing specific caluses trough DocumentWithSignature.tsx
  • flashing, first and subsequent when viewing with DocumentViewer.tsx

List of changes proposed in this pull request

  • reset document downloadUrl pot when FciDocumentsScreen.tsx loses focus

How to test

  • start signing process
  • view first document
  • view second document
  • when viewing second document the previous document is not shown for a splitsecond
before.mp4
after.mp4

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@freddi301 freddi301 added Bug 🐞 IO-Ecosystem Links IO - Ecosystem Links labels Feb 11, 2026
@freddi301 freddi301 changed the title fix [IEL-56] fix: [IEL-56] Pdf flashing during sign Feb 11, 2026
@freddi301
Copy link
Copy Markdown
Contributor Author

for investigation purposes, this commit 7c15d18 hides wiht opacity 0 the pdf component instance while loading. This may indicated that the problem might be that old previous content is shown while loading the most recent one.
Not all instances of the problem are solved and other solution must be found.
The file is FciDocumentsScreen.tsx, also the fix should be replicated onto DocumentWithSignature.tsx

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.58%. Comparing base (12d85cb) to head (bbe701e).

Files with missing lines Patch % Lines
.../features/fci/screens/valid/FciDocumentsScreen.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7857      +/-   ##
==========================================
- Coverage   60.58%   60.58%   -0.01%     
==========================================
  Files        1947     1947              
  Lines       43016    43018       +2     
  Branches     9872     9871       -1     
==========================================
+ Hits        26063    26064       +1     
- Misses      16874    16876       +2     
+ Partials       79       78       -1     
Files with missing lines Coverage Δ
.../features/fci/screens/valid/FciDocumentsScreen.tsx 63.21% <50.00%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d85cb...bbe701e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR mitigates a PDF “flashing” glitch in the FCI signing flow by ensuring the previously downloaded preview path isn’t reused when returning to the documents screen (the screen stays mounted across navigation changes).

Changes:

  • Clear the fciDownloadPreview pot when FciDocumentsScreen loses focus.
  • Keep existing focus-triggered download behavior for the currently selected document.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ts/features/fci/screens/valid/FciDocumentsScreen.tsx
Comment thread ts/features/fci/screens/valid/FciDocumentsScreen.tsx
Comment thread ts/features/fci/screens/valid/FciDocumentsScreen.tsx Outdated
Comment thread ts/features/fci/screens/valid/FciDocumentsScreen.tsx Outdated
Comment thread ts/features/fci/screens/valid/FciDocumentsScreen.tsx Outdated
@Ladirico Ladirico closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 IO-Ecosystem Links IO - Ecosystem Links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants