Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
|
for investigation purposes, this commit 7c15d18 hides wiht opacity 0 the pdf component instance while loading. This may indicated that the problem might be that old previous content is shown while loading the most recent one. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7857 +/- ##
==========================================
- Coverage 60.58% 60.58% -0.01%
==========================================
Files 1947 1947
Lines 43016 43018 +2
Branches 9872 9871 -1
==========================================
+ Hits 26063 26064 +1
- Misses 16874 16876 +2
+ Partials 79 78 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR mitigates a PDF “flashing” glitch in the FCI signing flow by ensuring the previously downloaded preview path isn’t reused when returning to the documents screen (the screen stays mounted across navigation changes).
Changes:
- Clear the
fciDownloadPreviewpot whenFciDocumentsScreenloses focus. - Keep existing focus-triggered download behavior for the currently selected document.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Short description
This PR addresses a graphical glitch happening when viewing pdf documents to sign.
It happens when changing screen. There three variations of this:
After a thorough investigation we discovered that it was due to downloadUrl pot contains previous document url when viewwing the affected screens.
Affected components:
In the end we decided to fix only one occurrence, since there weren't issue reported from users:
We left unsolved the other:
List of changes proposed in this pull request
How to test
before.mp4
after.mp4