Conversation
…ione-delega-tra-ui-ed-evento-mixpanel
…ione-delega-tra-ui-ed-evento-mixpanel
…ione-delega-tra-ui-ed-evento-mixpanel
…ione-delega-tra-ui-ed-evento-mixpanel
…ra-ui-ed-evento-mixpanel' of https://github.com/pagopa/io-app into IOCOM-2990-be-disallineamento-step-validazione-delega-tra-ui-ed-evento-mixpanel
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7897 +/- ##
==========================================
+ Coverage 60.04% 60.05% +0.01%
==========================================
Files 1967 1968 +1
Lines 43915 43929 +14
Branches 10139 10141 +2
==========================================
+ Hits 26367 26381 +14
Misses 17460 17460
Partials 88 88
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…-errore-per-la-gestione-del-ttl
|
🎉 All dependencies have been resolved ! |
…-errore-per-la-gestione-del-ttl
There was a problem hiding this comment.
Pull request overview
Adds support for rendering dedicated UI error screens for specific SEND AAR delegation failures (TTL/mandate-related) during mandate validation and mandate creation, by extending the AAR problem-json error mapping and introducing new error components with related tests/i18n.
Changes:
- Extended
getAarErrorBehaviourmapping to support new status+errorCode combinations and added two new error components. - Added/updated component tests and snapshots to cover the new screens.
- Added Italian i18n strings for the new error screens.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/features/pn/aar/utils/aarErrorMappings.ts | Adds new error codes and status mappings to render the new TTL/pending-delegation screens. |
| ts/features/pn/aar/utils/tests/aarErrorMappings.test.tsx | Expands mapping test matrix and mocks constVoid for new behaviours. |
| ts/features/pn/aar/components/errors/SendAarPendingDelegationErrorComponent.tsx | New “pending delegation” error screen component for mandate creation flow. |
| ts/features/pn/aar/components/errors/SendAarCieValidationErrorComponent.tsx | Adds CieValidationExpiredTtlComponent for mandate validation TTL expiry. |
| ts/features/pn/aar/components/errors/tests/SendAarPendingDelegationErrorComponent.test.tsx | Tests snapshot + flow termination for the new pending-delegation screen. |
| ts/features/pn/aar/components/errors/tests/SendAarCieValidationErrorComponent.test.tsx | Adds tests for the new CIE validation TTL-expired component. |
| ts/features/pn/aar/components/errors/tests/snapshots/SendAarPendingDelegationErrorComponent.test.tsx.snap | Snapshot for the new pending-delegation component. |
| ts/features/pn/aar/components/errors/tests/snapshots/SendAarCieValidationErrorComponent.test.tsx.snap | Snapshot for the new CIE validation TTL-expired component. |
| locales/it/index.json | Adds Italian translations for the new error screen texts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-errore-per-la-gestione-del-ttl
…-errore-per-la-gestione-del-ttl
…-errore-per-la-gestione-del-ttl
…-errore-per-la-gestione-del-ttl
…-errore-per-la-gestione-del-ttl
…-errore-per-la-gestione-del-ttl
Short description
--- 🔴 DEPENDS ON #7880 🔴 ---
this PR introduces the logic required to display the correct error screens in case of a TTL error in both the mandate creation and mandate validation steps of the AAR delegation flow
List of changes proposed in this pull request
How to test
Also, using either the dev-server or proxy software (e.g. proxyman):
PN_MANDATE_ALREADYEXISTS} as the first entry in theerrorsarray should result in its specific error screen. no other configuration (e.g. different http code, different error as the first entry) should result in the same screen.PN_MANDATE_NOTFOUND} as its first entry in theerrorsarray should behave the same way as the mandate creation response logic.