Conversation
There was a problem hiding this comment.
Pull request overview
Renames/rebrands the project from “LumenForge” to “JForge” across Java packages, UI strings, storage locations, build metadata, CI, and scripts so the codebase, artifacts, and documentation consistently reflect the new name.
Changes:
- Updated Java package declarations/imports from
atri.palaash.lumenforge.*toatri.palaash.jforge.*. - Renamed user-facing identifiers (window title, logs, temp-file prefixes, system properties) and default storage directory to
~/.jforge-models. - Updated build/release plumbing (Maven coordinates, main class, GitHub Actions artifacts) plus README and scripts.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/atri/palaash/jforge/inference/GenericOnnxServiceTest.java | Updates test package/imports and temp directory prefix for the new app name. |
| src/main/java/atri/palaash/jforge/ui/TextToImagePanel.java | Updates imports and switches local model/log paths to ~/.jforge-models and jforge.log. |
| src/main/java/atri/palaash/jforge/ui/SimpleDocumentListener.java | Package rename to atri.palaash.jforge.ui. |
| src/main/java/atri/palaash/jforge/ui/PromptPreset.java | Package rename to atri.palaash.jforge.ui. |
| src/main/java/atri/palaash/jforge/ui/PromptLibraryPanel.java | Moves prompt library persistence path under ~/.jforge-models. |
| src/main/java/atri/palaash/jforge/ui/NativeLookAndFeel.java | Package rename + theme override property renamed to jforge.theme. |
| src/main/java/atri/palaash/jforge/ui/ModelManagerPanel.java | Package/import renames + updates user-facing strings/log prefixes from LumenForge to JForge. |
| src/main/java/atri/palaash/jforge/ui/MainFrame.java | Package/import renames + updates window title/brand label to “JForge”. |
| src/main/java/atri/palaash/jforge/ui/Img2ImgPanel.java | Package/import renames + temp mask file prefix updated to jforge-mask-. |
| src/main/java/atri/palaash/jforge/ui/ImageUpscalePanel.java | Package/import renames + switches local model/log paths to ~/.jforge-models. |
| src/main/java/atri/palaash/jforge/ui/HistoryPanel.java | Moves history persistence path under ~/.jforge-models. |
| src/main/java/atri/palaash/jforge/ui/HistoryEntry.java | Package rename to atri.palaash.jforge.ui. |
| src/main/java/atri/palaash/jforge/storage/PyTorchToOnnxConverter.java | Package rename + updates venv path/docs and embedded script header branding. |
| src/main/java/atri/palaash/jforge/storage/ModelStorage.java | Package/import rename + default model root changed to ~/.jforge-models. |
| src/main/java/atri/palaash/jforge/storage/ModelDownloader.java | Package/import renames + updates console log prefixes to [JForge]. |
| src/main/java/atri/palaash/jforge/storage/DownloadProgress.java | Package rename to atri.palaash.jforge.storage. |
| src/main/java/atri/palaash/jforge/model/TaskType.java | Package rename to atri.palaash.jforge.model. |
| src/main/java/atri/palaash/jforge/model/ModelRegistry.java | Package rename to atri.palaash.jforge.model. |
| src/main/java/atri/palaash/jforge/model/ModelDescriptor.java | Package rename to atri.palaash.jforge.model. |
| src/main/java/atri/palaash/jforge/inference/ServiceFactory.java | Package/import renames to atri.palaash.jforge.*. |
| src/main/java/atri/palaash/jforge/inference/InferenceService.java | Package rename to atri.palaash.jforge.inference. |
| src/main/java/atri/palaash/jforge/inference/InferenceResult.java | Package rename to atri.palaash.jforge.inference. |
| src/main/java/atri/palaash/jforge/inference/InferenceRequest.java | Package/import renames to atri.palaash.jforge.*. |
| src/main/java/atri/palaash/jforge/inference/GenericOnnxService.java | Package/import renames + updates log prefixes and EP override property to jforge.ep. |
| src/main/java/atri/palaash/jforge/app/JForgeApp.java | Renames the app entrypoint class/package and updates startup logs + macOS app name. |
| scripts/export_torchscript.py | Updates branding and default output dir under ~/.jforge-models. |
| scripts/convert_pytorch_to_onnx.py | Updates branding and default output dir under ~/.jforge-models. |
| pom.xml | Updates Maven coordinates/artifact name and main class references to JForge. |
| README.md | Updates branding, links, storage path, and EP override flag to -Djforge.ep. |
| .vscode/tasks.json | Updates VS Code task labels from LumenForge → JForge. |
| .github/workflows/build.yml | Updates workflow name and artifact naming/patterns to jforge-*.jar. |
Comments suppressed due to low confidence (7)
src/main/java/atri/palaash/jforge/ui/ImageUpscalePanel.java:409
runInference()hard-codes~/.jforge-modelsfor the manual-import path check. Since this class already has aModelStorageinjected, consider usingmodelStorage.modelPath(model)/modelStorage.root()instead so the behavior respects non-default storage roots and avoids duplicating the storage path logic (same applies toopenLogsFolder()below).
src/main/java/atri/palaash/jforge/ui/HistoryPanel.java:24- Changing the persistence location to
~/.jforge-models/history.jsonwill make existing users’ history appear empty after upgrading from the previous app name. Consider migrating/copying the old~/.lumenforge-models/history.jsonon first run (or checking both locations).
src/main/java/atri/palaash/jforge/ui/PromptLibraryPanel.java:27 - Changing the persistence location to
~/.jforge-models/library.jsonwill make existing users’ saved presets disappear after upgrading from the previous app name. Consider migrating/copying the old~/.lumenforge-models/library.jsonon first run (or checking both locations).
src/main/java/atri/palaash/jforge/storage/ModelStorage.java:16 - Changing the default model root to
~/.jforge-modelsis a breaking behavior change for existing users who already have models/cache under~/.lumenforge-models. Consider a one-time migration (or fallback lookup to the old directory when the new one is empty) to avoid making previously downloaded models/history disappear after upgrade.
src/main/java/atri/palaash/jforge/inference/GenericOnnxService.java:2687 - The execution-provider override system property was renamed to
jforge.ep. To preserve backwards compatibility for existing launch scripts, consider also checkinglumenforge.epas a fallback whenjforge.epis not set (and/or logging a deprecation warning).
src/main/java/atri/palaash/jforge/ui/NativeLookAndFeel.java:167 - The theme override property was renamed to
jforge.theme. If this property is used externally (scripts/docs), consider reading the oldlumenforge.themeas a fallback (or documenting the rename) to avoid silently breaking existing configurations.
src/main/java/atri/palaash/jforge/ui/TextToImagePanel.java:365 - This panel hard-codes
~/.jforge-modelsin a few places (e.g., manual local-path checks and log paths) even though the class already accepts aModelStorageinstance. Consider deriving these paths frommodelStorage.root()/modelStorage.modelPath(...)so custom storage roots work consistently and the path isn’t duplicated across panels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [](https://github.com/palaashatri/jforge/actions/workflows/build.yml) | ||
|
|
||
| Desktop Java Swing application for ONNX Runtime inference with intelligent GPU acceleration across NVIDIA, Apple, Intel, and AMD hardware. | ||
|
|
||
| <img width="2552" height="2026" alt="image" src="https://github.com/user-attachments/assets/8b7a8783-c795-4a2f-844c-beccc9d6855d" /> | ||
|
|
There was a problem hiding this comment.
The README screenshot/image tag was removed as part of this rename-only PR. If that wasn’t intentional, consider restoring it (or replacing it with an updated screenshot) so the README still has a visual preview of the app.
No description provided.