Add comment for #2644#2657
Open
fsamuel-bs wants to merge 2 commits intodevelopfrom
Open
Conversation
aldexis
reviewed
Aug 19, 2025
…gChannel.java Co-authored-by: Alexis Le Dantec <53899003+aldexis@users.noreply.github.com>
pkoenig10
reviewed
Aug 19, 2025
| if (requestCanBeRetried() && shouldAttemptToRetry(clientSideThrowable)) { | ||
| callsiteStacktrace.ifPresent(clientSideThrowable::addSuppressed); | ||
| Meter retryReason = retryDueToThrowable.apply(clientSideThrowable); | ||
| // Retry immediately when we failed to reach the server, since it wasn't a capacity issue |
Member
There was a problem hiding this comment.
Just because we are in this code path does not mean we failed to reach the server.
| callsiteStacktrace.ifPresent(clientSideThrowable::addSuppressed); | ||
| Meter retryReason = retryDueToThrowable.apply(clientSideThrowable); | ||
| // Retry immediately when we failed to reach the server, since it wasn't a capacity issue | ||
| // Note that this should retry on another node with DialogueNodeSelectionStrategy.BALANCED, |
Member
There was a problem hiding this comment.
"should" feels like too strong of language here. There is no guarantee that we will retry on another node.
I would phrase this like "It is expected that most of the time the request will be retried on another node..."
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
See #2644 (comment)
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?