fix fluid width to fill only needed space#164
Closed
yoelbassin wants to merge 0 commit intopalerdot:masterfrom
Closed
fix fluid width to fill only needed space#164yoelbassin wants to merge 0 commit intopalerdot:masterfrom
yoelbassin wants to merge 0 commit intopalerdot:masterfrom
Conversation
Owner
|
@yoelbassin Thanks for the PR. Much appreciated. Can you change the base of the branch to https://github.com/palerdot/react-d3-speedometer/tree/react-v18 If you can change the base and update the PR against |
Author
|
Reopened in #165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Have been using this project for a while now, and always had this problem, so I decided to create a PR about it.
Until now, when using
fluidWidth={true}, the gauge filled the entire div it was in, even though it used only half of the space.Case study 1:
Before:


After:
Case study 2:
Before:

After:
