Skip to content

Add segment click functionality#180

Open
sayzard wants to merge 1 commit intopalerdot:masterfrom
sayzard:click_segment
Open

Add segment click functionality#180
sayzard wants to merge 1 commit intopalerdot:masterfrom
sayzard:click_segment

Conversation

@sayzard
Copy link

@sayzard sayzard commented Feb 6, 2024

Retrieve label and range value when clicking on segments

ex) Segment clicked: Awesome! 750-1000

@palerdot
Copy link
Owner

palerdot commented Feb 6, 2024

Please open a new issue explaining the introduction of new prop onSegmentClick.

While the prop name and functionality looks ok, the arguments (and the order) do not. I prefer an object with label, text keys since it is easier to introduce new keys in the future without the hassle of remembering the function argument order.

onSegmentClick({ label, text} )

I can consider this PR, if an issue explaining the PR is opened along with necesssary function argument changes.

I would also prefer a test for the onSegmentClick changes with a mock function.

PS: I cannot guarantee a timeline for integrating this into the main codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants