Skip to content

fix - #570 - hit indication always true#579

Closed
idoshr wants to merge 3 commits intopallets-eco:masterfrom
idoshr:fix-hit-cache-#570
Closed

fix - #570 - hit indication always true#579
idoshr wants to merge 3 commits intopallets-eco:masterfrom
idoshr:fix-hit-cache-#570

Conversation

@idoshr
Copy link
Copy Markdown
Contributor

@idoshr idoshr commented Jul 14, 2024

hit indication return always true on hit indication

Checklist:

  • [ x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • [x ] Add or update relevant docs, in the docs folder and in code.
  • [ x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • [ x] Add .. versionchanged:: entries in any relevant code docs.
  • [ x] Run pre-commit hooks and fix any issues.
  • [ x] Run pytest and tox, no tests failed.

@idoshr idoshr changed the title tester fix - #570 - hit indication always true Jul 14, 2024
@sh4nks sh4nks mentioned this pull request Apr 17, 2026
6 tasks
@sh4nks
Copy link
Copy Markdown
Collaborator

sh4nks commented Apr 17, 2026

Thanks! The implementation in #596 seemed to be a bit less complex so I went with the other implementation but I added your tests.

@sh4nks sh4nks closed this Apr 17, 2026
sh4nks added a commit that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

response_hit_indication hit_cache always True once set

3 participants