Potential fix for code scanning alert no. 3235: Multiplication result converted to larger type#139
Closed
bniladridas wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 3235: Multiplication result converted to larger type#139bniladridas wants to merge 1 commit into
bniladridas wants to merge 1 commit into
Conversation
… converted to larger type Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Contributor
|
☑️ I checked the pre-commit hooks and there was nothing to fix at commit |
bniladridas
added a commit
that referenced
this pull request
May 4, 2026
Combines all 15 automated code scanning alert fixes for multiplication result converted to larger type. These changes span `include/stb_image.h`, `include/stb_image_write.h`, and `src/preprocess.c` with consistent application of `size_t` casts to prevent integer overflow before conversion to larger types. Overflow checks are added where allocation sizes are stored back into `int` variables such as `out_size`. > [!NOTE] > Merging this pull request will automatically close #125, #126, #127, #128, #129, #130, #131, #132, #133, #134, #135, #136, #137, #138, #139 --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Niladri Das <bniladridas@users.noreply.github.com>
Member
Author
|
Fixed in #140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/bniladridas/hybrid-compute/security/code-scanning/3235
To fix this safely without changing behavior for valid inputs, ensure allocation-size multiplications are performed in a wider unsigned type (
size_t) before multiplication, and reject impossible sizes when they exceedINT_MAXwhere the code still stores byte counts inint(out_size,delays_size).Best fix in this region:
include/stb_image.h, inside the shown GIF loading block (around lines 7729–7759), compute:size_t alloc_size = (size_t)layers * (size_t)stride;size_t delays_alloc = (size_t)layers * sizeof(int);if (alloc_size > INT_MAX)/if (delays_alloc > INT_MAX)and return existing OOM/error path.size_tvalues to allocation/reallocation macros.intonly after bounds check when assigning toout_size/delays_size.No new external dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.