Conversation
amotl
force-pushed
the
postgresql
branch
6 times, most recently
from
bc0e856 to
fa45e53
Compare
Otherwise, `language_data` renders like `var stopwords = ;`, which is invalid code.
amotl
force-pushed
the
postgresql
branch
2 times, most recently
from
872a273 to
28603bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Instead of using SQLite like the original package atsphinx-sqlite3fts, this patch explores how it can be made work to use other SQL databases which provide FTS features, like PostgreSQL with corresponding extensions, or CrateDB without further ado.
Details
Because this will not be able to pull off the same trick of embedding the SQLite database into the browser, accessing it through WASM, it will be far behind from a convenience standpoint, because it will also need to accompany a little backend service wrapping the search request.
Because our intention is to use the search-as-you-type UI widget readthedocs-sphinx-search, we will probably make it so that this little middleware service will be compatible, to make it easy to swap this in.