Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the repository's build and testing infrastructure by migrating from tox to hatch for package management and testing.
Key Changes:
- Migrated testing dependencies from
project.optional-dependenciestotool.hatch.envs.tests - Updated GitHub Actions workflow to use
hatchinstead oftoxfor building and publishing - Incremented version number in CHANGELOG to 0.2.3
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Removed project.optional-dependencies.testing section and pytest configuration; added hatch test environment with dependencies and test scripts |
| CHANGELOG.md | Updated version number from 0.2.2 to 0.2.3 |
| .github/workflows/create-release.yml | Replaced tox commands with hatch equivalents for building the package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ] | ||
| [tool.hatch.envs.tests.scripts] | ||
| test = "pytest" | ||
| test-cov = "pytest --cov=panoptes.data --cov-report term-missing --verbose" |
There was a problem hiding this comment.
The pytest configuration options previously defined in [tool.pytest.ini_options] (including norecursedirs and testpaths) have been removed. Consider adding a [tool.pytest.ini_options] section back with norecursedirs = ['dist', 'build'] and testpaths = ['tests'] to maintain the same test discovery behavior.
Suggested change
| test-cov = "pytest --cov=panoptes.data --cov-report term-missing --verbose" | |
| test-cov = "pytest --cov=panoptes.data --cov-report term-missing --verbose" | |
| [tool.pytest.ini_options] | |
| norecursedirs = ["dist", "build"] | |
| testpaths = ["tests"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Udpating testing and build to use
hatch.