Configurable file names for embedding applications#1
Merged
Conversation
Add ToolInfo struct and parameterized variants of key library functions so embedding apps (like slyds) can customize config file names, vendor directory names, lock file names, and generated content branding. New APIs: - FindVendorConfigWithNames(startDir, configNames) - LoadVendorConfigWithDefaults(path, ToolInfo) - WriteVendorReadmeFor(vendorDir, ToolInfo) - WriteLockFileFor(path, lock, ToolInfo) Original functions preserved as backward-compatible wrappers. CLI updated to use library constants (DefaultLockFile). Also adds: - CI workflow (test on push/PR, release on tag via goreleaser) - Pre-push hook running tests - SHA-pinned GitHub Actions for supply chain security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolInfostruct and parameterized variants of key library functions so embedding apps (like slyds) can customize config file names, vendor directory names, lock file names, and all generated content brandingFindVendorConfig,LoadVendorConfig,WriteVendorReadme,WriteLockFile) preserved as backward-compatible wrappers — zero breaking changesDefaultLockFile) instead of hardcoded stringsgo test ./...Closes panyam/slyds#34 (templar side — slyds integration is a separate PR)
New APIs
FindVendorConfig(dir)FindVendorConfigWithNames(dir, names)LoadVendorConfig(path)LoadVendorConfigWithDefaults(path, info)WriteVendorReadme(dir)WriteVendorReadmeFor(dir, info)WriteLockFile(path, lock)WriteLockFileFor(path, lock, info)Test plan
go test ./...passesgo build ./cmd/templarsucceeds