Conversation
|
Thanks for your contribution! We don't accept pull requests to the |
jtaala
previously requested changes
Mar 29, 2025
Collaborator
There was a problem hiding this comment.
Looks good. Would just need a quick update to the README.md and will be good to go.
I've update the README.md.
Nice work @Thesola10!
jtaala
reviewed
Mar 29, 2025
Collaborator
jtaala
left a comment
There was a problem hiding this comment.
Tested functions.
Install and generating zip works well!
Uninstall did work, but I did get an error there:
[jay@m16 pwm]$ make uninstall
GNOME_EXT_DISABLE paperwm@paperwm.github.com
/bin/sh: -c: line 6: syntax error: unexpected end of file
make: *** [Makefile:68: uninstall] Error 2
Member
|
Personally I like:
That way,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tentative change which removes a few of the shell scripts at the repo root, by merging them into a single Makefile.
Feedback is welcome!