Fix compatibility with GNOME 49#1077
Conversation
Maximization API rename broke PaperWM: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4415
|
FYI I tested this locally and it seems to work ok. |
| return Scratch.isScratchWindow(metaWindow); | ||
| } | ||
|
|
||
| export function isMaximized(metaWindow) { |
There was a problem hiding this comment.
ℹ️ (Just a comment, nothing to change here)
👍 I think these wrappers around gnome-shell functionality are great. The less one needs to know about gnome-shell internals in order to contribute high-level functionality to PaperWM, the better.
In the future, we should talk about organizing all the stuff that's currently in tiling.js.
- Currently I don't see any clear logic for when to create a top level function, a method on
Space, or a method onSpaces. - There's not a clear separation of space-local operations and global ones (that work based on the current focused monitor/workspace/window).
- We don't have any public/private separation, which means that renaming anything might break someone's customizations (e.g. stuff in
examples/).
Today though, I don't have a good enough understanding of all the stuff that exists to know how to organize it, so here is fine for now. Since they're not exported, we can always move them later.
|
I am confused here. why does this PR still require approvals given two reviewers have already approved the changes? |
|
@capfredf Probably because the topmost commit is by smichel17 and GitHub doesn't count the last committer's approval |
5 participants
Maximization API rename broke PaperWM:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4415