Fix: #10. Add Rolebinding#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #10 by adding support for RoleBinding resources and refactoring related resource handling in the K8s resource module.
- Removed duplicate definitions of get_app_uri and the old label property.
- Introduced a new label property that now includes a mapping for RoleBinding.
- Added new Role and RoleBinding classes with appropriate apiVersion and kind properties, and updated CLASSMAP accordingly.
Files not reviewed (1)
- d3fendtools/kuberdf/ontology.ttl: Language not supported
| yield user_u, NS_D3F.accesses, self.ns | ||
|
|
||
| else: | ||
| raise NotImplementedError(kind) |
There was a problem hiding this comment.
Consider providing a more descriptive error message in RoleBinding.triple_spec to clarify which subject kind is unsupported, for example: raise NotImplementedError(f'Unsupported subject kind: {kind}').
Suggested change
| raise NotImplementedError(kind) | |
| raise NotImplementedError(f"Unsupported subject kind: {kind}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR