Remove invalid required=True from click.argument with nargs=-1#17
Merged
Conversation
Merged
Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com>
Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback on pyscript bump PR
Remove invalid required=True from click.argument with nargs=-1
Jan 8, 2026
ioggstream
approved these changes
Jan 8, 2026
ioggstream
added a commit
that referenced
this pull request
Jan 8, 2026
* Fix placement of Service and Deployment in Namespace. * Preliminary bump pyscript. * Remove invalid required=True from click.argument with nargs=-1 (#17) * Initial plan * Fix click.argument usage by removing required=True and adding validation Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com> * Add required=True to --output option to prevent None value Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: ioggstream <1140844+ioggstream@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@click.argumentdecorator was usingrequired=Truewithnargs=-1, creating a semantic conflict—nargs=-1means "0 or more" whilerequired=Trueimplies "at least 1". Click's argument class accepts therequiredparameter, but using it with variadic arguments is non-idiomatic.Changes:
required=Truefrom@click.argumentdecoratorclick.UsageErrorrequired=Trueto--outputoption to prevent None value errorsBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.