This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Place scheduled on sectionQuery, use startDate from schedule.#249
Draft
Shinsina wants to merge 1 commit intoparameter1:masterfrom
Draft
Place scheduled on sectionQuery, use startDate from schedule.#249Shinsina wants to merge 1 commit intoparameter1:masterfrom
Shinsina wants to merge 1 commit intoparameter1:masterfrom
Conversation
zarathustra323
suggested changes
Feb 15, 2022
| else: '$expires', | ||
| }, | ||
| }, | ||
| scheduled: '$startDate', |
Member
There was a problem hiding this comment.
What's this intended to be used for?
Member
Author
Member
There was a problem hiding this comment.
For what purpose? Section query intentionally uses published date to correct certain schedule start dates... in that example, that start date is actually wrong... you shouldn't be able to start content before it's actually published. Nothing in the interface prevents this, per se, hence why section query enforces this
Member
Author
There was a problem hiding this comment.
I don't agree with the idea of putting dates prior to the publish date anywhere.
Member
|
@Shinsina we're going to hold on these changes for now, pending some other options |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Ref: #247