fix: enhance charts to support Envoy Gateway based on feedback#417
Merged
andibeuge merged 4 commits intofeat/inf-3308-adapt-charts-envoy-gatewayfrom Jan 30, 2026
Merged
Conversation
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>
andibeuge
approved these changes
Jan 30, 2026
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Enhance charts to support Envoy Gateway based on feedback
Add validation for HTTPRoute hosts requirement
Jan 30, 2026
ecea7dd
into
feat/inf-3308-adapt-charts-envoy-gateway
4 checks passed
andibeuge
added a commit
that referenced
this pull request
Feb 2, 2026
* feat: inf-3308 adapt charts to support Envoy Gateway * feat: inf-3308 adapt charts to support Envoy Gateway * feat: inf-3308 adapt charts to support Envoy Gateway * feat: inf-3308 adapt charts to support Envoy Gateway * chore: updates based on tests with FBA * chore: updatae monolith * chore: linted and added sample values to microservice for gateway * chore: added value samples to monolith * chore: rename file * chore: rename file * chore: delete unused tempalte * fix: add validation to prevent invalid ReferenceGrant resources (#418) * Initial plan * fix: add validation to ReferenceGrant template to prevent invalid resources Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> * fix: enhance charts to support Envoy Gateway based on feedback (#417) * Initial plan * Add validation for HTTPRoute hosts requirement Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> * Use idiomatic len check for empty hosts validation Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> * chore: remove invalid block * Update parcellab/monolith/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update parcellab/common/templates/_referencegrant.tpl Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: correct policy namespace * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Andreas Beuge <andreasbeuge@abs-bmbp.fritz.box> Co-authored-by: Andreas Beuge <andreasbeuge@abs-bmbp.local> Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #413: HTTPRoute template would generate invalid resources if
hostsis undefined or empty. Gateway API requires at least one hostname.Changes:
requiredcheck forhttpRoutes[].hostsfieldeq (len $hosts) 0$hostsvariable throughoutPattern:
{{- $hosts := required (printf "envoy.httpRoutes[%d].hosts is required" $index) $route.hosts -}} {{- if eq (len $hosts) 0 -}} {{- fail (printf "envoy.httpRoutes[%d].hosts cannot be empty" $index) -}} {{- end -}}Follows validation patterns established in
_securitypolicies.tpland_referencegrant.tpl. Provides clear error messages with array index for debugging.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.