Skip to content

fix: enhance charts to support Envoy Gateway based on feedback#417

Merged
andibeuge merged 4 commits intofeat/inf-3308-adapt-charts-envoy-gatewayfrom
copilot/sub-pr-413
Jan 30, 2026
Merged

fix: enhance charts to support Envoy Gateway based on feedback#417
andibeuge merged 4 commits intofeat/inf-3308-adapt-charts-envoy-gatewayfrom
copilot/sub-pr-413

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Addresses feedback from #413: HTTPRoute template would generate invalid resources if hosts is undefined or empty. Gateway API requires at least one hostname.

Changes:

  • Added required check for httpRoutes[].hosts field
  • Added empty array validation using eq (len $hosts) 0
  • Refactored template to use validated $hosts variable throughout

Pattern:

{{- $hosts := required (printf "envoy.httpRoutes[%d].hosts is required" $index) $route.hosts -}}
{{- if eq (len $hosts) 0 -}}
{{- fail (printf "envoy.httpRoutes[%d].hosts cannot be empty" $index) -}}
{{- end -}}

Follows validation patterns established in _securitypolicies.tpl and _referencegrant.tpl. Provides clear error messages with array index for debugging.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 30, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • charts.bitnami.com
    • Triggering command: /usr/local/bin/helm helm dependency build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Enhance charts to support Envoy Gateway based on feedback Add validation for HTTPRoute hosts requirement Jan 30, 2026
@andibeuge andibeuge changed the title Add validation for HTTPRoute hosts requirement fix: enhance charts to support Envoy Gateway based on feedback Jan 30, 2026
Copilot AI requested a review from andibeuge January 30, 2026 08:33
@andibeuge andibeuge marked this pull request as ready for review January 30, 2026 08:35
@andibeuge andibeuge requested review from a team as code owners January 30, 2026 08:35
@andibeuge andibeuge merged commit ecea7dd into feat/inf-3308-adapt-charts-envoy-gateway Jan 30, 2026
4 checks passed
@andibeuge andibeuge deleted the copilot/sub-pr-413 branch January 30, 2026 08:36
andibeuge added a commit that referenced this pull request Feb 2, 2026
* feat: inf-3308 adapt charts to support Envoy Gateway

* feat: inf-3308 adapt charts to support Envoy Gateway

* feat: inf-3308 adapt charts to support Envoy Gateway

* feat: inf-3308 adapt charts to support Envoy Gateway

* chore: updates based on tests with FBA

* chore: updatae monolith

* chore: linted and added sample values to microservice for gateway

* chore: added value samples to monolith

* chore: rename file

* chore: rename file

* chore: delete unused tempalte

* fix: add validation to prevent invalid ReferenceGrant resources (#418)

* Initial plan

* fix: add validation to ReferenceGrant template to prevent invalid resources

Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>

* fix: enhance charts to support Envoy Gateway based on feedback (#417)

* Initial plan

* Add validation for HTTPRoute hosts requirement

Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>

* Use idiomatic len check for empty hosts validation

Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>

* chore: remove invalid block

* Update parcellab/monolith/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update parcellab/common/templates/_referencegrant.tpl

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: correct policy namespace

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Andreas Beuge <andreasbeuge@abs-bmbp.fritz.box>
Co-authored-by: Andreas Beuge <andreasbeuge@abs-bmbp.local>
Co-authored-by: andibeuge <97287249+andibeuge@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants