Skip to content

fix: in order to support changes not only on dedicatd values.yaml file #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andibeuge merged 1 commit into from
Jan 30, 2026
Merged

fix: in order to support changes not only on dedicatd values.yaml file #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/kubernetes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ jobs:
cd remote
git config user.email "$GIT_USER_EMAIL"
git config user.name "$GIT_USER_NAME"
git add ".chart/$ENV/values.yaml"
git add .
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error in PR title: "dedicatd" should be "dedicated"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using git add . adds all modified files in the remote directory, which is more flexible than the previous hardcoded path but less explicit. Consider the following:

  1. The commit message on line 205 specifically mentions "set $ENV image tag to $VERSION", which may not accurately describe all changes if multiple files are modified
  2. While the change fixes the mismatch between the hardcoded path and the actual file being modified (line 193), using git add . could inadvertently commit unintended files if the workflow is modified in the future to create additional temporary files

If this flexibility is intentional to support different deployment structures (as suggested by the PR description), consider updating the commit message to be more generic, or adding a comment explaining why all files are being added rather than just the modified values.yaml file.

Copilot uses AI. Check for mistakes.
if git diff --cached --quiet; then
echo "No changes to commit"
exit 0
Expand Down