fix(ui): keep preimage lookup polling#74
Closed
pgherveou wants to merge 1 commit into
Closed
Conversation
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: c67ede0 |
Contributor
⚡ Performance Report
|
15a7569 to
f003f70
Compare
ff8115e to
95b810c
Compare
e3568dd to
68b7853
Compare
68b7853 to
344ac80
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the host-side preimage lookup stream alive after transient IPFS gateway or bitswap failures.
The Rust core treats lookup as a subscription and performs hash-integrity verification. Ending that stream on a single backend error prevents later replication from ever becoming visible. This layer logs transient backend failures and lets the existing polling interval try again.
It also makes the bitswap startup warning accurate in RPC gateway mode.
Base
Stacked on #70. This behavior fix is intentionally outside the architecture migration diff.
Verification
bun run test tests/preimage.test.tsbunx eslint src/bulletin-bitswap.ts src/host-callbacks/Preimage.ts