fix(ui): preserve notification sessions#75
Closed
pgherveou wants to merge 1 commit into
Closed
Conversation
Contributor
⚡ Performance Report
|
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: 4a0c5c0 |
pgherveou
force-pushed
the
codex/dotli-preserve-notification-sessions
branch
2 times, most recently
from
f084ccc to
c571d95
Compare
pgherveou
force-pushed
the
codex/dotli-preserve-notification-sessions
branch
from
c571d95 to
86ddccf
Compare
Contributor
Author
|
Superseded by #70: the notification no-reload behavior is required for the Rust core request/response lifecycle, so the implementation and regression coverage were absorbed into the architecture PR. Keeping this dependent PR open now duplicates that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid reloading the product after notification permission is granted.
A reload is required when a browser-enforced iframe permission changes, but notifications are mediated through the host callback and do not alter the iframe
allowpolicy. Reloading here unnecessarily tears down the newly established core session.Base
Stacked on #70. This lifecycle fix is intentionally separate from the architecture migration.
Verification
bun run test tests/notification.test.tsbunx eslint src/host-callbacks/PromptPermission.ts