fix: updates in diagnosis report + submit report button#277
Open
Imod7 wants to merge 2 commits into
Open
Conversation
valentinfernandez1
requested changes
Jul 14, 2026
| if (status === "pass") pass++; | ||
| else if (status === "fail") fail++; | ||
| else if (status === "skipped") skip++; | ||
| // Skipped rows carry the ⏭ marker; the compatibility-matrix aggregator |
Collaborator
There was a problem hiding this comment.
Let's not change the current diagnosis view behavior, skipped methods should show as failed and the reason why they were skipped but let's not remove them from the matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
playground/src/lib/auto-test.ts- skipped methods now carry a short reason ("service not yet wired up by hosts" / "host surface intentionally deferred") so the Details column isn't empty.playground/src/components/DiagnosisView.tsx- the on-screen summary now shows a skipped count. "Submit report" copies the full report to the clipboard and puts a smaller version (success details dropped) in the issue URL.playground/src/lib/diagnosis-report.ts- the report gets aN success · N failed · N skippedsummary line and now lists skipped rows. Adds a compact mode (drops success details) and a URL-length cap: if the report is still too big, the issue opens with a "paste from clipboard" note instead of failing.rust/crates/truapi/src/api/signing.rs- fixes thesign_payload_with_legacy_accountexample, which used an incomplete call payload the phone couldn't decode ("fails to load"). Now uses the same valid payload assign_payload.playground/CLAUDE.md- updates the file descriptions to match the above.Notes
⏭) cells and only reads pass/fail.