Conversation
deobald
left a comment
deobald
left a comment
There was a problem hiding this comment.
Sapna, can you please pull the changes from the master branch to make sure everything is in sync before we merge? Thanks!
There was a problem hiding this comment.
Hi Sapna. Can you please remove these .DS_Store files and add .DS_Store to the .gitignore file? These are temporary files created by the Mac and should not be checked in.
lib/app/I18n.dart
Outdated
| "videos": "Videos" | ||
| "videos": "Videos", | ||
| "All": "All", | ||
| "No videos found.": "No videos found.", |
There was a problem hiding this comment.
Instead of keying on the phrase (ex. "No videos found.") can you please key on an all-lowercase key with no spaces? (ex. "old_student"). What is there will compile but this is just a stylistic preference so keys can also be variable names, if required.
lib/app/I18n.dart
Outdated
| "All": "All", | ||
| "No videos found.": "No videos found.", | ||
| "Search video here..": "Search video here..", | ||
| "a-z": "A-Z", |
There was a problem hiding this comment.
Since hyphens can't be used in variable names, these keys are better written as "a_z" etc.
3 participants
Added videos search functionality and videos category buttons.