Skip to content

fix: File metadata endpoint returns HTTP 200 instead of 403 for invalid app ID #10527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dblythy wants to merge 1 commit into
base: alpha
Choose a base branch
from
+6 −5
Open

fix: File metadata endpoint returns HTTP 200 instead of 403 for invalid app ID #10527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/ParseFile.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,9 @@ describe('Parse.File testing', () => {
it('does not crash on file metadata request with invalid app ID', async () => {
const res1 = await request({
url: `http://localhost:8378/1/files/invalid-id/metadata/invalid-file.txt`,
});
expect(res1.status).toBe(200);
expect(res1.data).toEqual({});
}).catch(e => e);
expect(res1.status).toBe(403);
expect(res1.data).toEqual({ error: 'Permission denied' });
// Ensure server did not crash
const res2 = await request({ url: 'http://localhost:8378/1/health' });
expect(res2.status).toEqual(200);
Expand Down
5 changes: 3 additions & 2 deletions src/Routers/FilesRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,9 @@ export class FilesRouter {
try {
const config = Config.get(req.params.appId);
if (!config) {
res.status(200);
res.json({});
const error = createSanitizedHttpError(403, 'Invalid application ID.', config);
res.status(error.status);
res.json({ error: error.message });
return;
}
FilesRouter._validateFileDownload(req, config);
Expand Down
Loading