refactor: Document intentional expired-token match in password reset resend flow

[dblythy]

Closes #9935

Summary by CodeRabbit

• Documentation
  • Added clarification around password reset behavior to help preserve the correct experience for expired reset links and email resends.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 859085d5-f865-4584-be3f-9e2b536b2281

📥 Commits

Reviewing files that changed from the base of the PR and between 7e9d53a and b8028b2.

📒 Files selected for processing (1)

• src/Routers/UsersRouter.js

---

📝 Walkthrough

Walkthrough

Added an explanatory comment block in handleResetRequest within UsersRouter.js, documenting that the $lt comparison for _perishable_token_expires_at is intentional for the resend password reset email flow and should not be changed to $gt.

Changes

Reset Token Query Documentation

Layer / File(s)	Summary
Explanatory comment on token expiry query src/Routers/UsersRouter.js	Adds a documentation-only comment clarifying that the $lt comparison intentionally matches expired tokens to support the resend password reset email flow, and warns against changing it to $gt.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

• parse-community/parse-server#10128: Both PRs touch UsersRouter.handleResetRequest's token-lookup logic, one clarifying the $lt/$gt comparison intent and the other adding validation against injection via such operators.

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only says "Closes #9935" and omits the required Issue, Approach, and Tasks sections.	Add the template sections with the linked issue, a brief approach summary, and the relevant task checklist items.
Linked Issues check	⚠️ Warning	The PR does not implement #9935's required $gt comparator, limit 1, or Auth.maintenance; it only adds a comment.	Update the lookup to use $gt with Parse._encode(new Date()), pass { limit: 1 }, and use Auth.maintenance(req.config).

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is prefixed correctly and matches the password-reset token lookup change.
Out of Scope Changes check	✅ Passed	No unrelated code changes are present; the only edit is a comment in the affected password reset flow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check	✅ Passed	No executable code changed; the touched block only adds documentation, so no new security vulnerability is introduced.
Engage In Review Feedback	✅ Passed	No substantive review feedback is present in the PR context, so there was nothing to ignore or resolve without engagement.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.66%. Comparing base (cce91e5) to head (b8028b2).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10533   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         193      193           
  Lines       16981    16981           
  Branches      248      248           
=======================================
  Hits        15736    15736           
  Misses       1224     1224           
  Partials       21       21           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dblythy]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[dblythy]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.