Fix for crash when compiling module with no parameters.#128
Open
gjcoram wants to merge 26 commits intopascalkuthe:masterfrom
Open
Fix for crash when compiling module with no parameters.#128gjcoram wants to merge 26 commits intopascalkuthe:masterfrom
gjcoram wants to merge 26 commits intopascalkuthe:masterfrom
Conversation
Author
|
This is the correct commit. Apparently, having a dummy parameter interns the empty string (possibly the unit or description of the parameter), so that the later lookup of the empty string finds a match. |
Signed-off-by: Geoffrey Coram <gjcoram@users.noreply.github.com>
to address $mfactor issue for flow probes See pascalkuthe#107
See pascalkuthe@42026b1 but note this is a different change
|
@gjcoram |
I guess you went and officially forked this? are you mantaining it? |
Author
I hope to continue to improve it. |
|
I get something weird trying to merge this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #103