Open
Conversation
KnorpelSenf
commented
Feb 3, 2026
| } | ||
|
|
||
| fn estimate_tokens(&self) -> u32 { | ||
| self.as_str().len() as u32 |
Contributor
Author
There was a problem hiding this comment.
There might be a better heuristic than this. Perhaps we should do
Suggested change
| self.as_str().len() as u32 | |
| 256.min(self.as_str().len() as u32) |
instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of the changes in #33 in order to add support for character diffs. Should be reviewed only after #33 is merged. The diff is here: KnorpelSenf/imara-diff@word-diff...KnorpelSenf:imara-diff:char-diff
While a character diff can technically be performed directly on a line diff, this implementation supports performing a character diff on top of a word diff, too. That way, one can: