Skip to content

Fixed callback if DialogFragment called from an other Fragment#39

Open
yurezcv wants to merge 4 commits into
passy:masterfrom
yurezcv:master
Open

Fixed callback if DialogFragment called from an other Fragment#39
yurezcv wants to merge 4 commits into
passy:masterfrom
yurezcv:master

Conversation

@yurezcv

@yurezcv yurezcv commented Sep 23, 2014

Copy link
Copy Markdown

Good day to you.

I have been trying to use your library in my own project.
And I found out that if I start DialogFragment from an Fragment then I don't receive the interface callback there, but I receive it on Activity which has started this Fragment.
So I decided to add small changes to your library.

Please, check it, if everything is allright I will be very happy to help you :)

@yurezcv yurezcv changed the title Fixed callback if DiaglogDragment called from an other Fragment Fixed callback if DialogFragment called from an other Fragment Sep 23, 2014
@passy

passy commented Sep 26, 2014

Copy link
Copy Markdown
Owner

Thanks for the patch. I think that's a good idea. Do you think you could also add some tests for around the new behavior?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now have proper checks in place, we no longer need to catch the ClassCastException

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@passy

passy commented Nov 5, 2014

Copy link
Copy Markdown
Owner

@yurezcv Hey, are you still interested in getting this in?

@yurezcv

yurezcv commented Nov 5, 2014

Copy link
Copy Markdown
Author

@passy Hi, sorry. I have a lot of stuff to do. But I'm interested.
Could you tell me what changes I should apply to get this pull request accepted?
Thank you in advance.

@passy

passy commented Nov 5, 2014

Copy link
Copy Markdown
Owner

@yurezcv No worries, I'm in the same boat. :)

Just the two things mentioned above, ie. the class cast and removing the unnecessary changes to the XML files.

@passy

passy commented Jan 15, 2015

Copy link
Copy Markdown
Owner

ping

@yurezcv

yurezcv commented Jan 19, 2015

Copy link
Copy Markdown
Author

I'm here :)
I didn't get what you mean in "removing unnecessary changes to the XML files.
There are only necessary changes. And I have already removed the class cast, but didn't push it yet.

@passy

passy commented Jan 19, 2015

Copy link
Copy Markdown
Owner

@yurezcv Cool, the rest is okay the way it is. So it's only left to the class cast. :)

@b3nson

b3nson commented Nov 19, 2015

Copy link
Copy Markdown

hey,
why got this pull-request never merged???
are you planning to do so?
would urgently need the "DialogFragment called from an other Fragment"-functionality (getTargetFragment())
:)
thanks.

@passy

passy commented Nov 19, 2015

Copy link
Copy Markdown
Owner

@b3nson I don't have time to pick this up at the moment. Do you want to address the comments? Would be happy to review it.

@b3nson

b3nson commented Nov 20, 2015

Copy link
Copy Markdown

@passy check pull request here: #72
Only changes to the library-project, removed ClassCastException, no XML-changes.
Is that what you meant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants