Support .obsm backed color specs in val.viz.embedding#97
Open
JhonatanFelix wants to merge 7 commits intopatcon:mainfrom
Open
Support .obsm backed color specs in val.viz.embedding#97JhonatanFelix wants to merge 7 commits intopatcon:mainfrom
.obsm backed color specs in val.viz.embedding#97JhonatanFelix wants to merge 7 commits intopatcon:mainfrom
Conversation
Owner
|
thanks! will aim to review today, though maaaaybe tomorrow 🙏 |
Author
|
Hi @patcon, I wanted to follow up on this PR in case it got buried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #55
This draft PR is meant to cover a small V1 for supporting
.obsm-backed color specs inval.viz.embeddingPlanned scope for this work:
Parser / expansion
Add private parsing and expansion helpers for color specs like
foo[2]and bounded slices likefoo[2:6]while keeping normal.obskeys unchanged.val.viz.embeddingwrapperReplace the current direct re-export with a small wrapper that resolves
.obsmvector specs, creates temporary.obscolumns on a copy ofadata, and then forwards the rewrittencolorargument toscanpy.pl.embedding.Tests and polish
Add focused unit tests for the parsing and wrapper behavior and plus a small smoke test to make sure the feature works end-to-end without mutating the original
adata.For this V1, I’m intentionally keeping the scope pretty "small":
foo[i]foo[a:b].obscolor keysfoo[:]out for nowChecklist
CHANGELOG.mdupdated under[Unreleased](required for user-facing changes)