add support of mysqlnd driver (alternative to libmysqlclient)#45
add support of mysqlnd driver (alternative to libmysqlclient)#45remicollet wants to merge 2 commits intopatrickallaert:masterfrom
Conversation
- move query text in header (defined only once)
a7e0e05 to
4444abd
Compare
- json for socket driver - mysqlnd for mysqlnd driver
patrickallaert
left a comment
There was a problem hiding this comment.
I am very much in favor of supporting mysqlnd! I also think it should be the default as of APM 2.2 (new version), what is your opinion on that?
However, I think this should not be implemented as another driver, but rather defining macros that would abstract the mysql or mysqlnd API that would be used under the hood.
That way, it also prevents having both drivers at the same time, which is something I would prefer not to support.
Opinions?
|
By supporting mysqlnd using macros around mysql API, this would dramatically reduce the number of lines of duplicated code. |
+1 (having dependency on libmysqlclient is not friendly, especially when PHP don't have it anymore)
This is already not alllowed (if ... elseif ...)
This was only a prrof of concept ;) btw this is about lot of conditional vs duplicated code. I will try to see if a can update this PR (time...) |
Mostly a proof of concept (tests needed)