fix for issue #82#87
Open
afdev82 wants to merge 1 commit intopatricklindsay:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've spent some time to dig into the code.
At least for me, these changes fixed the issue #82.
Since I'm not familiar with the source code, I don't know if this is a good solution and if it would work for other DBMS (e.g. MySQL).
I've tested it with my application using a dropdown filter and a Postgresql DB. Actually I'm using the branch compatible with Rails 6.1 from kreintjes repo.
I haven't applied the same change to all processors, because I wanted to have a feedback before.