Update OilSource.scala#155
Open
daprof1 wants to merge 1 commit intopatsonluk:masterfrom
Open
Conversation
So found this bug on my retro server. It only shows up when the actual cycle sim time is less than the scheduled time. Main sim runs the cycle then increments the week. This causes the current oil prices (for contracts, etc) not be able to load (and then defaults to 70) as it's requesting "NEXT WEEK" if you check prices during the time the simulator has finished with the last week but hasn't started the next week. Of course you could just change the order of the main sim actor so it increments first then triggers start cycle, but due to consistency concerns I did it this way.
Owner
|
@daprof1 Just want to see where Dairy is 🥛 The game has been getting a lot of updates and a Christmas event! Going to work on V2 soon too! Where's the UI update!!?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So found this bug on my retro server. It only shows up when the actual cycle sim time is less than the scheduled time. Main sim runs the cycle then increments the week. This causes the current oil prices (for contracts, etc) not be able to load (and then defaults to 70) as it's requesting "NEXT WEEK" if you check prices during the time the simulator has finished with the last week but hasn't started the next week.
Of course you could just change the order of the main sim actor so it increments first then triggers start cycle, but due to consistency concerns I did it this way.