docs(menu, select, app launcher, dropdown): Updates images for v6.#4643
Merged
Conversation
Collaborator
edonehoo
reviewed
Jun 4, 2025
Collaborator
There was a problem hiding this comment.
This is a little nit picky, but it's a bit difficult for me to see what's going on in this image due to the size (especially the group header and the truncation). Could you try scooting the 3 examples closer together to see if that helps when they're scaled?
Might just be me right now, if we can't do much with it that's fine
Contributor
Author
There was a problem hiding this comment.
I tweaked the spacing a little bit, but not sure if that helped?
Contributor
|
For the split button image do we need the toggle group and input groups in the image?
Under select it looks like the checkboxes in the Figma file didn't show in the PR. |
andrew-ronaldson
approved these changes
Jun 18, 2025
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
Aug 1, 2025
…atternfly#4643) * docs(menu, select, app launcher, dropdown): Updates images for v6. * Updating images. * Updating image issues. * Adding badge count to menu * Fixing menu text --------- Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4555