Skip to content

chore(overflow): update images#4646

Merged
andrew-ronaldson merged 6 commits into
patternfly:mainfrom
andrew-ronaldson:overflow
Jun 9, 2025
Merged

chore(overflow): update images#4646
andrew-ronaldson merged 6 commits into
patternfly:mainfrom
andrew-ronaldson:overflow

Conversation

@andrew-ronaldson
Copy link
Copy Markdown
Contributor

Closes #4560

@andrew-ronaldson andrew-ronaldson requested a review from edonehoo June 4, 2025 14:47

<img src="./img/cardoverflow.png" alt="image showing card overflow" width="370" />
<div class="ws-docs-content-img">
![image showing card overflow](./img/toolbarcardoverflowoverflow.svg)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![image showing card overflow](./img/toolbarcardoverflowoverflow.svg)
![image showing card overflow](./img/cardoverflow.svg)

this is causing the build error I think!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe break this apart into 2 images, so that they can be a little easier to see (even the v5 images it's hard to see the headings)

Also I think the second heading should say "desktop toolbar" or something similar!

Copy link
Copy Markdown
Collaborator

@edonehoo edonehoo Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion about maybe breaking this into 2 images to help with readability 🙈 (and also accessibility so we can have separate alt texts)

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, ty!

@andrew-ronaldson andrew-ronaldson merged commit df38b6d into patternfly:main Jun 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guideline updates: Overflow menu

3 participants