docs(modal): Updates images for v6.#4654
Merged
Merged
Conversation
Collaborator
edonehoo
reviewed
Jun 13, 2025
Collaborator
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
just wondering if some of the more complex images could be made larger for better readability?
otherwise, looks good!
Collaborator
kaylachumley
left a comment
kaylachumley
left a comment
There was a problem hiding this comment.
looks good! i left a few comments - also agree with erins comment about making the images a bit larger
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
edonehoo
reviewed
Jun 16, 2025
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
edonehoo
reviewed
Jun 16, 2025
edonehoo
approved these changes
Jun 16, 2025
…delines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
Aug 1, 2025
* docs(modal): Updates images for v6. * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Updating image context. * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/modal/modal.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> --------- Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4556