docs(overflow-menu): Updates content for v6.#4656
Merged
Merged
Conversation
Collaborator
bekah-stephens
requested changes
Jun 17, 2025
Contributor
bekah-stephens
left a comment
bekah-stephens
left a comment
There was a problem hiding this comment.
nit-picky thing (and not docs related). since the images PR isn't open anymore, can you do a quick image swap? I updated the "mobile-toolbar-overflow" image in Figma, so it just needs to be replaced (the text options in the menu didn't match the rest)
Contributor
bekah-stephens
left a comment
bekah-stephens
left a comment
There was a problem hiding this comment.
update looks good! but I found another small thing 🫣 on the images that have "Link" or "Disabled link" as a menu option, should the text be link text? or have an external link button?
Collaborator
Author
|
@bekah-stephens from what I understand from our docs, I think the only menu link styling is the external link icon? So I added that, but lmk if there's something different there! |
andrew-ronaldson
approved these changes
Jul 14, 2025
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
Aug 1, 2025
* docs(overflow-menu): Updates content for v6. * Mobile toolbar image swap. * Update links in images. --------- Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4650