docs(toolbar): Updates images for v6.#4674
Conversation
|
@edonehoo there are some content updates needed (replacing px info with spacer info) |
kaylachumley
left a comment
kaylachumley
left a comment
There was a problem hiding this comment.
left some comments! ty! sorry for being nit - semantic spacers are always tough
|  | ||
| </div> | ||
|
|
||
| Toolbar items are individual components that can be placed inside of a toolbar. Often, it makes sense to group sets of like items to create desired associations and to enable items to respond together to changes in viewport width. The default spacing between items and groups is 16px, but this can be modified, if required. The following are some toolbar items and groups that come with special spacing considerations. |
There was a problem hiding this comment.
few things:
-
I thought the semantic spacer between toolbar items is
pf-t--global--spacer--gap--action-to-action--defaultbut spacers still get me at times so this is a good question for lucia. its the same amount of px as the md spacer but just aligns better semantically. I also reference this old doc for spacer assistance if I can't get an answer from org.. could also be out of date but 🤷♀️ -
wondering if we should link users to the semantic spacers page to help with documentation if they try to modify the 16px padding?
-
should we or remove the part entirely saying"but this can be modified, if required"? asking bc im not sure if we want to encourage users to use a different spacer than we originally recommend?
There was a problem hiding this comment.
+1 to removing the part about modifying, because we don't even have guidance for that, so I think that should only be something we support when people ask? or at least I think we shouldn't state it here without a great place to link to
|  | ||
| </div> | ||
|
|
||
| A bulk selector can be added when you want to give users the ability to select multiple items within a page. Besides allowing the user to select and deselect all items on a page, other application specific options can be added in the dropdown. Bulk selection allows the user to select or deselect all items on a page and provide an indeterminate state that notifies the user when only some items are selected. Bulk selectors should always be the left-most element in a toolbar and has a 24px spacer to its right. |
There was a problem hiding this comment.
wondering if we should link the bulk selector page here too https://www.patternfly.org/patterns/bulk-selection/#bulk-selector ?
also not sure if we want to reference the specific semantic spacer used instead of '24px'? i think that would be pf-t--global--spacer--action--horizontal--default but again deff a better lucia question
|  | ||
| </div> | ||
|
|
||
| A search filter is intended to be used with a filter group as shown below when you want to include a single search field together with one or more select filters. It includes an 8px spacer to the right of the item to enforce association with other filters. See the [filters](/patterns/filters) documentation for more information about using search filters. |
There was a problem hiding this comment.
another one that will need some lucia input 🤓 on org the description for spacing between filter group items says to use pf-t--global--spacer--gap--control-to-control--default which is only 4px not 8px so not sure
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
these guidelines need a lot of content work in general tbh, so I'm going to open a follow-up issue.
Hopefully these suggestions are good enough for the time being
|  | ||
| </div> | ||
|
|
||
| Toolbar items are individual components that can be placed inside of a toolbar. Often, it makes sense to group sets of like items to create desired associations and to enable items to respond together to changes in viewport width. The default spacing between items and groups is 16px, but this can be modified, if required. The following are some toolbar items and groups that come with special spacing considerations. |
There was a problem hiding this comment.
+1 to removing the part about modifying, because we don't even have guidance for that, so I think that should only be something we support when people ask? or at least I think we shouldn't state it here without a great place to link to
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
just these 2 small typos and then I think this lgtm!
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…delines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
* docs(toolbar): Updates images for v6. * Fixing the sizing of an image. * Updating bulk selector component. * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Adjusting images. * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> * Update packages/documentation-site/patternfly-docs/content/design-guidelines/components/toolbar/toolbar.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> --------- Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
5 participants
Closes #4573