chore(timestamp): image updates#4686
Merged
Merged
Conversation
edonehoo
reviewed
Jul 2, 2025
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 3. **Time:** Should be displayed in 12-hour or 24-hour ((HH:MM:SS). [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | |
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](/ux-writing/numerics). |
this should work 🤞
edonehoo
reviewed
Jul 2, 2025
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 3. **Time:** Should be displayed in 12-hour or 24-hour ((HH:MM:SS). [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | ||
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | |
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](/ux-writing/numerics). |
edonehoo
reviewed
Jul 2, 2025
| 3. **Time:** Should be displayed in 12-hour or 24-hour ((HH:MM:SS). [See Numerics guidelines for more information](https://v4-archive.patternfly.org/v4/ux-writing/numerics). | ||
| 1. **Day:** Spelled out or abbreviated format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | ||
| 2. **Date:** Can be spelled out, abbreviated form, or digit format. [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | ||
| 3. **Time:** Should be displayed in 12-hour or 24-hour (HH:MM:SS). [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 3. **Time:** Should be displayed in 12-hour or 24-hour (HH:MM:SS). [See Numerics guidelines for more information](https://www.patternfly.org/ux-writing/numerics). | |
| 3. **Time:** Should be displayed in 12-hour or 24-hour (HH:MM:SS). [See Numerics guidelines for more information](/ux-writing/numerics). |
edonehoo
reviewed
Jul 2, 2025
| - Should be formatted the same as the timestamp. | ||
|
|
||
| See [numerics guidelines](https://v4-archive.patternfly.org/v4/ux-writing/numerics) for more information about relative time best practices. | ||
| See [numerics guidelines](https://www.patternfly.org/ux-writing/numerics) for more information about relative time best practices. |
Collaborator
There was a problem hiding this comment.
Suggested change
| See [numerics guidelines](https://www.patternfly.org/ux-writing/numerics) for more information about relative time best practices. | |
| See [numerics guidelines](/ux-writing/numerics) for more information about relative time best practices. |
Collaborator
|
I think these files just need to be dragged into the img folder (ignore me if they already are - I can't tell) |
bekah-stephens
requested changes
Jul 2, 2025
Contributor
There was a problem hiding this comment.
Generally a little confused by this screenshot. Is the second example just a tooltip version? I'm not sure the #5 annotation makes sense since it's calling out the dotted line (and there isn't one on the tooltip)
Contributor
Author
There was a problem hiding this comment.
I thought the same. The 5 on the dotted underline indicates there is a tooltip and 5 is also the tooltip?
Contributor
Collaborator
There was a problem hiding this comment.
yeah the current image is weird imo. Could you update the image so that the tooltip is shown above the timestamp? And then the #5 annotation just points to the tooltip
Like this, if that makes sense?
Collaborator
edonehoo
reviewed
Jul 2, 2025
Collaborator
There was a problem hiding this comment.
Oh--looking at the docs I think that tooltips need to be in UTC / I suppose that's the advised usage for them?
edonehoo
reviewed
Jul 2, 2025
Collaborator
There was a problem hiding this comment.
UTC in the timestamp here as well?
edonehoo
approved these changes
Jul 2, 2025
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4571