fix(docs-framework): updates to theme switcher menu/icons#4710
Merged
Conversation
Collaborator
Contributor
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
The only thing I would update is adding a pf-v6-u-font-size-md modifier so the icons are bigger in the button. The icon size in the menu is fine so just the menu toggle.
dlabaj
approved these changes
Jul 21, 2025
andrew-ronaldson
approved these changes
Jul 21, 2025
nicolethoen
pushed a commit
to nicolethoen/patternfly-org
that referenced
this pull request
Aug 1, 2025
…#4710) * fix(docs-framework): updates to theme switcher menu/icons * fix(theme switcher): apply brand icons * chore(theme-switcher): cleanup icons * chore(theme-switcher): bump menu toggle icon size --------- Co-authored-by: Andrew Ronaldson <aronalds@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4709
cc @andrew-ronaldson - feel free to push updates to this PR as you see fit!