Skip to content

fix: enable HC switcher, add beta label #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 6 commits into from
Oct 8, 2025
Merged

fix: enable HC switcher, add beta label #4766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
209c900
fix: enable HC switcher, add beta label
mcoker Sep 3, 2025
22170f8
chore: add labels, popover to theme switcher
mcoker Sep 16, 2025
c03ab80
chore: theme selector updates
mcoker Sep 16, 2025
57004d3
chore: remove unused import
mcoker Sep 16, 2025
89b819d
Update packages/documentation-framework/components/themeSelector/them…
mcoker Sep 30, 2025
0816d83
Update packages/documentation-framework/components/themeSelector/them…
mcoker Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 49 additions & 4 deletions packages/documentation-framework/components/themeSelector/themeSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,12 @@ import {
ToggleGroup,
ToggleGroupItem,
Icon,
Divider
Divider,
Label,
Popover,
Button
} from '@patternfly/react-core';
import { HelpIcon, ExternalLinkAltIcon } from '@patternfly/react-icons';
import { useTheme, THEME_TYPES } from '../../hooks/useTheme';

const SunIcon = (
Expand Down Expand Up @@ -45,6 +49,47 @@ const DesktopIcon = (
</svg>
);

const ColorSchemeGroupLabel = () => {
return (
<div className="pf-v6-c-menu__group-title" id="theme-selector-color-scheme-title">
Color scheme
</div>
);
};

const HighContrastGroupLabel = () => {
const [isPopoverOpen, setIsPopoverOpen] = useState(false);

return (
<div className="pf-v6-c-menu__group-title">
High contrast{' '}
<Popover
onClick={(e) => e.stopPropagation()}
headerContent={"Under development"}
headerComponent="h1"
bodyContent={
"We are still working to add high contrast support across all PatternFly components and extensions. This beta allows you to preview our progress."
}
footerContent={
<Button icon={<ExternalLinkAltIcon />} component="a" isInline variant="link" href="/design-foundations/theming" target="_blank">
Learn more
</Button>
}
aria-label="More info about high contrast"
appendTo={() => document.body}
>
<Button
variant="plain"
hasNoPadding
icon={<HelpIcon />}
aria-label="High contrast help"
/>
</Popover>{' '}&nbsp;
<Label color="blue" isCompact>Beta</Label>
</div>
)
};

export const ThemeSelector = ({ id }) => {
const { mode: themeMode, setMode: setThemeMode, modes: colorModes } = useTheme(THEME_TYPES.COLOR);
const {
Expand Down Expand Up @@ -109,8 +154,8 @@ export const ThemeSelector = ({ id }) => {
preventOverflow: true
}}
>
<SelectGroup>
<SelectList aria-label="Light/Dark theme switcher">
<SelectGroup label={ColorSchemeGroupLabel}>
<SelectList aria-labelledby="theme-selector-color-scheme-title">
<SelectOption value={colorModes.SYSTEM} icon={DesktopIcon} description="Follow system preference">
System
</SelectOption>
Expand All @@ -124,7 +169,7 @@ export const ThemeSelector = ({ id }) => {
</SelectGroup>
{process.env.hasHighContrastSwitcher && (<>
<Divider />
<SelectGroup label="High Contrast">
<SelectGroup label={HighContrastGroupLabel}>
<MenuSearch>
<MenuSearchInput>
<ToggleGroup aria-label="High contrast theme switcher">
Expand Down
2 changes: 1 addition & 1 deletion packages/documentation-site/patternfly-docs/patternfly-docs.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ if (process.env.EXTENSIONS_ONLY === 'true') {
hasDesignGuidelines: true,
hasThemeSwitcher: true,
hasFeedbackButton: true,
hasHighContrastSwitcher: false,
hasHighContrastSwitcher: true,
componentsData,
sideNavItems: [
{ section: 'get-started' },
Expand Down