Skip to content

docs(about-patternfly): Updates description of beta features.#4772

Merged
dlabaj merged 3 commits into
patternfly:mainfrom
edonehoo:iss4771
Oct 15, 2025
Merged

docs(about-patternfly): Updates description of beta features.#4772
dlabaj merged 3 commits into
patternfly:mainfrom
edonehoo:iss4771

Conversation

@edonehoo
Copy link
Copy Markdown
Collaborator

@edonehoo edonehoo commented Sep 5, 2025

Closes #4771

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Sep 5, 2025

Preview: https://pf-org--pr-4772-site.surge.sh

Comment on lines +14 to +19
.ws-docs-content-img {
text-align: center;
margin-inline: auto;
width: 100%;
max-width: 700px;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is with this class. It already exists but it's in the component design guidelines section

.ws-docs-content-img {
text-align: center;
margin-inline: auto;
width: 100%;
max-width: 700px;
}

It's fine as-is, I opened a follow-up issue that shows we have 3 separate classes we use for images (this would be a fourth) - I wonder if we could consolidate to one method and add that as a global class and remove these individual classes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that absolutely makes sense to sort out!

Copy link
Copy Markdown
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edonehoo edonehoo requested a review from dlabaj October 14, 2025 17:55
Copy link
Copy Markdown
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit 242425d into patternfly:main Oct 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - Expand definition of "beta"

4 participants