fix(ThemeSelector): Adjust popperProps#4787
Conversation
Prevent theme selector from overflowing container.
| )} | ||
| shouldFocusToggleOnSelect | ||
| onOpenChangeKeys={['Escape']} | ||
| popperProps={{ position: 'right', preventOverflow: true, enableFlip: true }} |
There was a problem hiding this comment.
Should we default to right when there's probably room to show it on the left?
There was a problem hiding this comment.
It flips when there's space! The other dropdown in the nav is right aligned already.
There was a problem hiding this comment.
Oh sorry I was specifically referring to the one in the masthead, which is the most prominent one. On org it's left aligned currently, but right aligned in this PR:
Org
This PR (added an extra user menu just to show there's space for it to be positioned to the left)
There was a problem hiding this comment.
Right! The release dropdown is right positioned already so I made it match. It looks a little funky to me otherwise, but I ultimately don't really care.
There was a problem hiding this comment.
Oh gotcha! I didn't realize you were comparing it to the version switcher. Checked with @lboehling and she's good with this change and prefers right aligned things here in general (search bar slides out from the right, too) 🚀
There was a problem hiding this comment.
Let's go with Sarah's; she backed out the other changes in her draft!
5 participants
Prevent theme selector from overflowing container. OK if we want to drop in favor of #4779; Sarah has the fix there too. I'd just want to assign the ticket to her so she gets credit.