Fix narrow code editor width issue in Label component demos#4793
Closed
nicolethoen wants to merge 1 commit into
Closed
Fix narrow code editor width issue in Label component demos#4793nicolethoen wants to merge 1 commit into
nicolethoen wants to merge 1 commit into
Conversation
Fixes code editor width issue on Label component React demos page by ensuring the .ws-code-editor element takes full width of its container. Fixes patternfly#4777 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
mcoker
reviewed
Sep 30, 2025
Contributor
There was a problem hiding this comment.
This is one way to fix it, but IMO the issue is that the main content area's width is defined by the width of the content and not a consistent width. I think it should be a consistent width, regardless the size of components and docs and stuff in the main content area.
You can see here that the width of the main content is max-width: min(100%, 825px), which effectively means width: 100%; max-widht: 825px;.
That would look a lot better if it were width: 825px; max-width: 100%;, or width: min(100%, 825px)
Also this may overlap with changes @srambach is making in #4802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
.ws-code-editorelement takes full width of its containerChanges
width: 100%andmax-width: nonefor.ws-code-editor.pf-v6-c-code-editorto ensure full widthpackages/documentation-framework/components/example/example.cssTest plan
yarn build)Fixes #4777
🤖 Generated with Claude Code