Separating the services into different POMs and adding docker#7
Open
galmarder wants to merge 14 commits into
Open
Separating the services into different POMs and adding docker#7galmarder wants to merge 14 commits into
galmarder wants to merge 14 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added docker to the demo. Now you can run the demo using docker as well.
To do it elegantly I have first separated the single project into 3 POMs, each representing a single service. This allows running each service using the
spring-boot:run.Then I have added a Dockerfile to each project so we can easily build an image for it.
Last, I have updated the Readme with all relevant instructions of how to run the demo using Docker.